Graceful shutdown for controller's namespace deletion

Aperta
#2,522 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

@csviri ci sta già lavorando.

Dal 29/8/2024.

  • #2528 di @csviri — integrata

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

Is your feature request related to a problem? Please describe.

This situation is a typical problem in integration tests (but not just). If the controller manages resources with finalizers in its namespace and the namespace gets deleted, in this case, the namespace deletion can get stuck since the pods of the operator are deleted before it can adequately finalize the resource (thus remove the finalizers).

Describe the solution you'd like

The ideal situation would be, that it waits until all the custom resources in the same namespace are cleaned up. (It might be also be possible to have such an intelligent shutdown hook).

Alternative would be just a simple shutdown hook to add that waits some time before it stops the controller. This might be trivial to add, does not require coding, but would be good to do add an integration test.

Additional context
see also: https://github.com/operator-framework/java-operator-sdk/issues/1876 - The finalizers would be needed if the operator has namespace scoped roles and rolebindings.

Notes:

For leader election, we might actually halt() instead of exit, which bypasses the shutdown hooks.

Lingua principale
Java
Stelle
944
Fork
242
Merge medio
1g 4h
PR unite (30g)
43

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di operator-framework/java-operator-sdk

Tutte le issue di operator-framework/java-operator-sdk

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.