"Maximum call stack size exceeded" running in Jest

Inizia leggendo lib/diff_line.js e riproduci il fallimento rieseguendo i test interessati in Jest watch mode. Traccia come vengono assegnati content e rawContent durante caricamenti ripetuti del modulo; il lavoro è completato quando le esecuzioni ripetute non ricorrono più fino a causare l’overflow dello stack delle chiamate, mentre la prima esecuzione continua a passare.

Having issues re-running some tests in Jest due to this line:

    RangeError: Maximum call stack size exceeded

      at DiffLine.Object.<anonymous>.DiffLine.content (node_modules/nodegit/dist/diff_line.js:13:13)
      at DiffLine.Object.<anonymous>.DiffLine.rawContent (node_modules/nodegit/dist/diff_line.js:29:22)
      at DiffLine.Object.<anonymous>.DiffLine.content (node_modules/nodegit/dist/diff_line.js:18:44)
      at DiffLine.Object.<anonymous>.DiffLine.rawContent (node_modules/nodegit/dist/diff_line.js:29:22)
      at DiffLine.Object.<anonymous>.DiffLine.content (node_modules/nodegit/dist/diff_line.js:18:44)
      at DiffLine.Object.<anonymous>.DiffLine.rawContent (node_modules/nodegit/dist/diff_line.js:29:22)
      at DiffLine.Object.<anonymous>.DiffLine.content (node_modules/nodegit/dist/diff_line.js:18:44)

Looks like prototype.content is reimplementing "native" content in JS land. But in doing so, it assumes the module is never "re-required" which is not always the case when running tests in Jest. When the module is imported the second time, _rawContent is referencing the JS implementation from the previous "require" and causing it to go into an infinite loop.

Just to be clear, the first run passes without issues. It's every run after that in watch mode that is an issue. I believe this is because the native modules are not reset between runs so closure over cached references isn't predictable.

A quick and dirty hack that fixes the issue:

var _rawContent = DiffLine._content = DiffLine._content || DiffLine.prototype.content;

Would this make an acceptable pull request? Or do you have a better way of addressing this issue?

System information

• node version: v16.13.0
• npm or yarn version: 8.3.0
• OS/version/architecture: darwin 21.3.0 arm64
• Applicable nodegit version: 0.28.0-alpha.11