StdioServerTransportProvider should support a stdin-close callback without interrupting shutdown
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 68/100
Direzione di ricerca
Inizia da StdioServerTransportProvider, in particolare dal ciclo di lettura di stdin e dalla gestione della terminazione di handleIncomingMessages(). Aggiungi il test di regressione suggerito per piped-stream, quindi verifica che il callback venga eseguito dopo la pulizia di session e inbound-sink, prima della dismissione dello scheduler, e che il thread del callback non venga interrotto.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
For stdio-based MCP servers, stdin closing is effectively the client disconnect signal. This is especially important when an MCP server runs in a container: once the MCP client disconnects or closes stdin, the server should be able to trigger application shutdown and clean up background resources.
Today, StdioServerTransportProvider closes the MCP session when stdin reaches EOF, but it does not expose a public transport-level callback that applications can use to run shutdown logic.
Downstream, we had to vendor/copy StdioServerTransportProvider to add such a callback.
Current behavior
When the stdin read loop exits, the SDK transport does roughly this:
finally {
isClosing.set(true);
if (session != null) {
session.close();
}
inboundSink.tryEmitComplete();
}
The session is closed, but the application has no direct hook to react to the stdio client disconnect.
There is also a subtle ordering issue. handleIncomingMessages() currently disposes the inbound scheduler from doOnTerminate():
this.inboundSink.asFlux()
.flatMap(message -> session.handle(message))
.doOnTerminate(() -> {
this.outboundSink.tryEmitComplete();
this.inboundScheduler.dispose();
})
.subscribe();
When stdin closes, the inbound read loop completes inboundSink. The termination callback can run on the same inbound thread. Disposing the scheduler there may call shutdownNow(), interrupting that same thread before downstream shutdown work has completed.
We observed this downstream: shutdown logic could run with the current thread interrupt flag already set, causing graceful shutdown to fail or exit early.
Expected behavior
StdioServerTransportProvider should allow applications to register an optional callback for stdin EOF / stdio client disconnect.
That callback should run:
- After the session is closed.
- After the inbound sink is completed.
- Before the inbound scheduler is disposed.
- Without the current thread being interrupted by scheduler disposal.
Proposed fix
Add an optional callback to StdioServerTransportProvider, for example as a Runnable:
public StdioServerTransportProvider(
McpJsonMapper jsonMapper,
InputStream inputStream,
OutputStream outputStream,
Runnable closeCallback
)
Or, if a reactive API is preferred:
Supplier<Mono<Void>> closeCallback
Then move inboundScheduler.dispose() out of handleIncomingMessages().doOnTerminate(...) and into the inbound read-loop finally, after the callback has completed.
The inbound read-loop cleanup would look conceptually like this:
finally {
isClosing.set(true);
if (session != null) {
session.close();
}
inboundSink.tryEmitComplete();
if (closeCallback != null) {
closeCallback.run();
}
inboundScheduler.dispose();
}
handleIncomingMessages() should still complete the outbound sink, but should not dispose the inbound scheduler from the termination callback.
Suggested regression test
Add a test that:
- Creates a
StdioServerTransportProviderwith a piped input stream. - Registers a callback.
- Starts the transport with a mock session.
- Closes the piped output stream to simulate stdin EOF.
- Verifies the callback runs.
- Verifies
Thread.currentThread().isInterrupted()isfalseinside the callback.
- Lingua principale
- Java
- Stelle
- 3.7k
- Fork
- 1.1k
- Merge medio
- 1g 15h
- PR unite (30g)
- 9
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di modelcontextprotocol/java-sdk
-
area/transport bug P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
modelcontextprotocol/java-sdk#1136 ·
-
area/client bug P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
modelcontextprotocol/java-sdk#1124 · 1 commento ·
-
ServerCapabilities.logging is added unconditionally, overriding the caller's explicit capabilities Apertabug P2 ready for work
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
modelcontextprotocol/java-sdk#1086 · 1 commento ·
-
enhancement good first issue P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
modelcontextprotocol/java-sdk#1067 ·
-
bug P2 ready for work
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
modelcontextprotocol/java-sdk#898 · 1 commento ·