Finding how to submit pending review comments is VERY hard

Aperta
#8,751 22 commenti 0 reazioni 1 assegnatario Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

info-needed
  • Extension version: 0.144.0
  • VSCode Version: 1.120.0
  • OS: Linux
  • Repository Clone Configuration (single repository/fork of an upstream repository): Single repo
  • GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): github.com

Steps to Reproduce:

  1. Check out a PR branch
  2. Use the "GitHub Pull Request" sidebar view to navigate files and add pending comments in the editor
  3. Struggle to find the "submit review" button
  4. Google how to do it, which suggests it should be in the command palette ... it is not
  5. Give up and go submit the pending review with a web browser
  6. Do this again 4 or 5 times
  7. Eventually discover that the embedded webview version of the PR can submit the pending comments

Why is there no more accessible button to submit the pending review? Loading the full web view for the PR is both non-discoverable, and it certainly feels like a very heavy weight and obtuse way to show a text box and 3 buttons.

I only even found that because of random right-clicking on things to see what the extension could do, and randomly came across Open Pull Request Description To The Side and clicked it purely out of curiosity, having no expectation that it would provide the only means I've found so far of surfacing the "Submit Review" button.

Lingua principale
TypeScript
Stelle
2.6k
Fork
796
Merge medio
16h 26m
PR unite (30g)
44

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/vscode-pull-request-github

Tutte le issue di microsoft/vscode-pull-request-github

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.