Fresh clone of repository results in many compilation errors

Aperta
#107 1 commento 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
28/100
Tipo di issue
Bug
Chiarezza
Da chiarire
Stato di attività
Ferma
Stack tecnologico
csharp
Ambito
build-system

Direzione di ricerca

Inizia con un clone pulito e prova a eseguire la build del repository, quindi esamina .editorconfig, Directory.Build.props e nuget.config alla luce degli errori di compilazione e delle origini dei pacchetti segnalati. Controlla nel README i prerequisiti per la build e documenta o correggi la configurazione del repository in modo che un checkout pulito venga compilato senza modifiche locali.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

I want to investigate implementing S3 compatibility for this. As an initial stab I wanted to get this compiled and working in my local environment. I tested this about a year ago and it worked fine but since then it seems like there have been some regressions.

I wanted to outline the fixes I had to implement to get this compiling in hopes that someone more familiar with the repository can provide guidance on the correct fixes for the main branch.

https://github.com/microsoft/MSBuildCache/blob/c1faabb1d036689b2421342ccf1e747d96ab2cf5/.editorconfig#L377
Had to change that to dotnet_diagnostic.IDE0055.severity = none # Fix formatting because there were a significant amount of errors after opening the solution.

https://github.com/microsoft/MSBuildCache/blob/c1faabb1d036689b2421342ccf1e747d96ab2cf5/Directory.Build.props#L37
Had to update this to ignore security vulnerability errors <NoWarn>$(NoWarn);NU5104;NU1901;NU1902;NU1903</NoWarn>. There were a lot of NuGet packages being flagged for vulnerabilities and preventing compilation.

The NuGet.config (https://github.com/microsoft/MSBuildCache/blob/main/nuget.config) had to be updated because it was failing to retrieve packages.
I had to do this:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <clear />
    <add key="nuget" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
    <add key="msbuildcache" value="https://pkgs.dev.azure.com/msbuildcache/public/_packaging/msbuildcache/nuget/v3/index.json" />
  </packageSources>
  <packageSourceMapping>
    <clear />
    <packageSource key="nuget">
      <package pattern="*" />
    </packageSource>
    <packageSource key="msbuildcache">
      <package pattern="RocksDb*" />
      <package pattern="Microsoft.BuildXL*" />
      <package pattern="Microsoft.Windows.Debuggers*" />
    </packageSource>
  </packageSourceMapping>
</configuration>

If there is something I missed that should have prevented the need to make these changes it would be appreciated if that could be called out in the README (or maybe I missed it altogether). If these are actual errors then I'm happy to help open PRs to try and fix the issues if a repository owner has guidance on what the correct fixes are.

Lingua principale
C#
Stelle
64
Fork
24
Merge medio
1g 14h
PR unite (30g)
2

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/MSBuildCache

Tutte le issue di microsoft/MSBuildCache

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.