barrierModel arity mismatch: "Expected 4, but was 3" on documented-correct 3-column rows (python-all, javascript-all)

Aperta
#22,597 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Ambito
security

Direzione di ricerca

Inizia riproducendo il fallimento da .github/codeql/extensions/.../models/log-injection.yml usando i bundle di CLI 2.26.4 e 2.27.0. Leggi ApiGraphModelsExtensions.qll e confronta la sua firma barrierModel con la forma documentata a tre colonne e i pack python-all/javascript-all. Il lavoro è completato quando hai confermato l’arità valida esposta all’utente e identificato se la correzione appartiene ai pack, alla validazione di CLI o alla documentazione.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

CodeQL fatally errors when resolving barrierModel data extensions for codeql/python-all and codeql/javascript-all, on rows that exactly match the documented, correct format (and the format used identically by sourceModel/sinkModel, per github/codeql#21004).

Repro

.github/codeql/extensions/.../models/log-injection.yml:

extensions:
  - addsTo:
      pack: codeql/python-all
      extensible: barrierModel
    data:
      - ["sciemo_one_client_base.safe_log", "Member[safe_log_value].ReturnValue", "log-injection"]

This is the exact format shown in the official docs (https://codeql.github.com/docs/codeql-language-guides/customizing-library-models-for-python/, "Example: Taint barrier using the 'escape' function") and matches barrierModel(type, path, kind) as formally declared in the Ruby docs' reference section.

Error

A fatal error occurred: A tuple in a data extension for the extensible predicate 'barrierModel' has an incorrect number of columns. Expected 4, but was 3.

What we tried

Assuming a genuine 4-column requirement (the trailing column being QlBuiltins::ExtensionId, per ApiGraphModelsExtensions.qll), we tried supplying a literal 4th value ourselves. None satisfy validation — all fail with:

ERROR: In extension for codeql/python-all:barrierModel, row 1 is invalid. Found '"...", "...", "log-injection", <value>', which does not match the signature 'barrierModel(string type, string path, string kind, [int origin])'.

Tried for <value>:

  • "manual" (string, matching the provenance convention used elsewhere in MaD, e.g. sourceModel/sinkModel)
  • 0 (int, repeated across rows)
  • unique sequential ints per row (1000, 1001, 1002)

All fail identically. Per github/codeql#21004, barrierModel's trailing param is QlBuiltins::ExtensionId madId, described as "the data extension row number" — auto-populated internally, never meant to be user-supplied (same as sinkModel/sourceModel, which only ever take 3 user columns). So there appears to be no valid literal a user can write to satisfy the 4-column requirement the arity check enforces.

Versions tried (same failure on both)

  • CLI 2.27.0 (codeql-bundle-v2.27.0, python-all 7.2.5 / javascript-all 2.10.1, via floating codeql-action@v4)
  • CLI 2.26.4 (codeql-bundle-v2.26.4, javascript-all/javascript-queries 2.4.4, via tools: pinned explicitly to the 2.26.4 bundle asset)

Both hit the identical Expected 4, but was 3 fatal error, and identical rejection of every literal 4th-column value tried.

Why this looks like a real bug, not user error

This is the same failure class as github/codeql-action#2706 (sourceModel arity mismatch, C#, "Expected 10, but was 9"), which was triaged as a genuine bug and fixed upstream, not a documentation/config issue on the reporter's side.

Impact

We currently work around this with continue-on-error: true on the analyze job, which means our repo has had no functioning CodeQL security scanning at all (all languages, not just the one with the custom model) since the analyze step fatally errors before any queries run.

Ask

  • Confirm whether barrierModel genuinely requires a 4th user-supplied column at these CLI versions, and if so, document the correct literal value for it.
  • If it should only take 3 columns (matching the documented examples and sourceModel/sinkModel's pattern), this looks like a packaging/version-skew bug between the compiled query pack and the python-all/javascript-all library pack.
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 11h
PR unite (30g)
129

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di github/codeql

Tutte le issue di github/codeql

Issue simili

Altre issue su Security

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.