Allow selecting HTTP transport in DBSQLClient.connect()
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 72/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- node.js, typescript
- Ambito
- api, networking
Direzione di ricerca
Inizia da lib/contracts/IDBSQLClient.ts e lib/DBSQLClient.ts, quindi esamina i test esistenti del trasporto HTTP e il test E2E del proxy HTTP. Verifica che le opzioni di connessione pubbliche espongano l’impostazione di trasporto concordata, che HTTPS rimanga quello predefinito e che una selezione esplicita di HTTP raggiunga l’implementazione di connessione esistente senza il workaround del metodo privato.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Please expose the existing HTTP transport support through the public DBSQLClient.connect() options.
I would be happy to submit a PR implementing this change if the maintainers agree with the proposed direction and public API.
The lower-level connection implementation supports both HTTP and HTTPS, but DBSQLClient currently hardcodes HTTPS.
Motivation
Some deployments connect to Databricks through a trusted local or internal reverse proxy, sidecar, or gateway:
Application --HTTP--> Internal proxy --HTTPS--> Databricks
In our concrete setup, authentication is also handled at the proxy level. The proxy injects the Databricks bearer token, while the application intentionally provides no authorization header.
This authentication arrangement is only one use case. The general issue is that callers cannot select the transport protocol for the endpoint supplied to DBSQLClient.
The existing proxy option does not address this scenario because it represents a forward proxy using CONNECT semantics, rather than a reverse proxy exposed as the Databricks endpoint.
Current behavior
The public ConnectionOptions type in lib/contracts/IDBSQLClient.ts does not expose an HTTP/HTTPS option.
Additionally, DBSQLClient.getConnectionOptions() in lib/DBSQLClient.ts hardcodes:
https: true,
Consequently, passing an untyped https: false value does not work: it is discarded and the client still connects using an https:// URL.
The internal implementation already appears to support the requested behavior:
IConnectionOptionsincludeshttps?: booleanHttpConnectionselects eitherhttp.Agentorhttps.AgentHttpConnectionconstructs either anhttp://orhttps://URL- existing tests exercise the HTTP behavior
- the HTTP proxy E2E test overrides
getConnectionOptions()to sethttps = false
Proposed API
Expose the existing option publicly while preserving HTTPS as the default:
await client.connect({
host: 'localhost',
port: 3015,
path: '/proxy/databricks/sql/1.0/warehouses/<warehouse-id>',
https: false,
authType: 'custom',
provider: {
async authenticate() {
return {};
},
},
});
The implementation could map it as follows:
https: options.https ?? true,
Alternatively, a more explicit public option could be introduced:
protocol?: 'http' | 'https';
HTTPS should remain the default, and HTTP should require explicit opt-in.
Current workaround
We currently override the private connection-options mapper:
type PublicConnectionOptions = Parameters<DBSQLClient['connect']>[0];
type InternalConnectionOptions = {
https?: boolean;
[key: string]: unknown;
};
type ClientConnectionOptionsFactory = {
getConnectionOptions(
options: PublicConnectionOptions,
): InternalConnectionOptions;
};
const client = new DBSQLClient();
const internalClient =
client as unknown as ClientConnectionOptionsFactory;
const getConnectionOptions =
internalClient.getConnectionOptions.bind(client);
internalClient.getConnectionOptions = (options) => ({
...getConnectionOptions(options),
https: false,
});
This works end to end and preserves the driver's normal connection handling, but it relies on a private method and may break between releases.
Security considerations
Plain HTTP should be documented as appropriate only for trusted local or private-network connections.
In our setup:
- the application-to-proxy connection is local/internal
- the proxy injects the Databricks token at the proxy layer
- the application does not send Databricks credentials over HTTP
- the proxy-to-Databricks connection uses HTTPS
Environment
@databricks/sql: 2.0.0
- Lingua principale
- TypeScript
- Stelle
- 36
- Fork
- 50
- Merge medio
- 13h 46m
- PR unite (30g)
- 9
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di databricks/databricks-sql-nodejs
-
Docs folder deleted in 1.8.4 Apertaengineer-bot
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
databricks/databricks-sql-nodejs#274 · 1 commento · 1 reazione ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 68/100
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 52/100