MachoView should define imported symbols even if they are not presented in SYMTAB

Aperta
#7,196 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
cpp
Ambito
reverse-engineering

Direzione di ricerca

Start in view/macho/machoview.cpp around line 3121, then inspect how DYLD_INFO binding strings are handled alongside the symtab loop. Open the attached binary, navigate to 0x100004000, and verify that the imported symbol referenced by binding is defined even when symtab.nsyms is zero, so relocation analysis no longer leaves a null external symbol.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Component: BinaryViewType Effort: Low File Format: Mach-O Impact: Medium

Version and Platform (required):

  • Binary Ninja Version: 5.2.8012-dev Personal (aec518eb)

Bug Description:
Current implementation of MachoView relies on symtab when defining the symbols in the macho. However it is possible to bind imported (external) symbols even if they are not in the symtab, as binding from DYLD_INFO uses their own inlined strings. So for the cases when symbol is used in the binding, but not listed in the symtab, leads to the error with applying relocation during macho analysis.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open attached binary
  2. Go to 0x100004000
  3. There is null instead of external symbol

Expected Behavior:
I think MachoView should define symbols when they referenced in the dyld binding as well.

Screenshots/Video Recording:

Image Image

Binary:
bin.zip

Additional Information:
Definition of the imported macho symbol is nested in the loop over symtab, so if there is no symbols (symtab.nsyms == 0) then no symbols will be defined, it's incorrect.

https://github.com/Vector35/binaryninja-api/blob/2f1d09c6b714a9f2664eab0a9dbef79e3cbd8919/view/macho/machoview.cpp#L3121

Lingua principale
C++
Stelle
1.3k
Fork
298
Merge medio
5g 5h
PR unite (30g)
19

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Vector35/binaryninja-api

Tutte le issue di Vector35/binaryninja-api

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.