process_one catches wrong QueueEmpty exception type
- Vorherrschende Sprache
- Python
- Sterne
- 734
- Forks
- 412
- Ø Merge
- 1 T. 5 Std.
- Gemergte PRs (30 T.)
- 8
Beschreibung
The `process_one` function [catches](https://github.com/ipython/ipykernel/blob/db5f708f66277110e4336cb4210a12d05323c564/ipykernel/kernelbase.py#L444) `asyncio.QueueEmpty`, but `msg_queue` is a tornado Queue and `get_nowait` [raises](https://github.com/tornadoweb/tornado/blob/aa9d32d5e89b290dad69e0c6655b7497ea492e45/tornado/queues.py#L272) its own [QueueEmpty](https://github.com/tornadoweb/tornado/blob/aa9d32d5e89b290dad69e0c6655b7497ea492e45/tornado/queues.py#L47) type, not the one in asyncio. This looks like it was part of the native async refactor for ipykernel 6, so I don't know if it's as simple as changing what type is caught, or if some other change needs to be made.
ipykernel 6.2, tornado 6.1
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.