ipython / ipython/ipykernel

echokernel example does not include topic in 'stream' responses

Offen
#69 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
734
Forks
412
Ø Merge
1 T. 5 Std.
Gemergte PRs (30 T.)
8

Beschreibung

I believe there is a bug in the [echokernel example kernel](http://jupyter-client.readthedocs.org/en/latest/wrapperkernels.html#example), specifically:

``` python
if not silent:
stream_content = {'name': 'stdout', 'text': code}
self.send_response(self.iopub_socket, 'stream', stream_content)
```

This is sending a message across the PUBSUB `iopub_socket`, but it doesn't include an `identity` argument, so there is no PUBSUB being prefixed to the message. The fix seems to be:

``` python
if not silent:
stream_content = {'name': 'stdout', 'text': code}
self.send_response(self.iopub_socket, 'stream', stream_content, ident=self._topic('stream'))
```

But I'm a tad hesitant to put it in a pull request because it seems intentional to make the `_topic` private. Does anyone know the right way to fix this?

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.