ZMQInteractiveShell.data_pub_class and datapub deprecation
- Dominant language
- Python
- Stars
- 734
- Forks
- 412
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 8
Description
I definitely don't understand understand everything that's going on here, but in hunting down a deprecation error in our tests, I noticed that the following line seems to be causing a `DeprecationWarning` related to `ipykernel.datapub` being [deprecated](https://github.com/ipython/ipykernel/blob/ef701eaac9adbc26eea6c2e0aa4452c838a27c81/ipykernel/datapub.py#L5):
https://github.com/ipython/ipykernel/blob/ef701eaac9adbc26eea6c2e0aa4452c838a27c81/ipykernel/zmqshell.py#L445
If I switch that line to
```python
class ZMQInteractiveShell(InteractiveShell):
...
data_pub_class = Type('ipyparallel.engine.datapub.ZMQDataPublisher')
```
then the deprecation warning goes away. of course, `ipyparallel` is not a dependency of `ipykernel`, so i guess that would break unless the user had it in their environment (or it was added as a dependency). What is the recommended "future-proof" approach here?
thanks!
Contributor guide
Assessment
This issue has not been assessed yet.