ipython / ipython/ipykernel

Constraints on ID size

Aperta
#253 8 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
734
Fork
412
Merge medio
1g 5h
PR unite (30g)
8

Descrizione

A lot of messages contain strings that are (typically) 32 bytes hexadecimal strings.

As I am working on a native implementation of the protocol, I realize that a lot of optimization is possible in e.g. comms if we know the size of the id in advance. Basically, a comm contains is a string, and fixed-sized stack allocated strings would prevent requiring dynamic allocation when instantiating a comm.

Hence, after some discussions on gitter, a proposition is to require the IDs specified in the jupyter messaging protocol to have a length of *up to* `32 bytes`.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.