iotile / iotile/python_archfx_cloud

ArchFxStreamSlug cannot handle an empty parent

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

A few tests that set the parent as `''` or `None` are failing. e.g.

https://github.com/iotile/python_archfx_cloud/blob/main/tests/test_slugs.py#L147

Need to fix that and reenable those tests. Passing `''` or `None` should be equivalent to passing a 0 and should represent `pl--0000-0000`

Note that we may have fixed that already on archfx_cloud: https://github.com/iotile/archfx_cloud/blob/master/server/apps/utils/gid/slugs.py

so need to diff with that file and update as needed. Once we deploy, the archfx_cloud should be replaced with this package

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.