ionic-team / ionic-team/rollup-plugin-node-polyfills
homeDir not exported by "os"
- Lenguaje dominante
- JavaScript
- Estrellas
- 142
- Forks
- 65
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Hello,
Thanks for your work on this excellent and critical piece of OSS.
I am experiencing an issue trying to polyfill the node os module in a Vite build that bundles some pieces of the AWS javascript SDK v3 with my application. Specifically, AWS is trying to import `homeDir` from "os", which is a part of the node module [here](https://nodejs.dev/learn/the-nodejs-os-module/#oshomedir), but is not exported by `rollup-plugin-node-polyfills/polyfills/os.js`
```
Error: 'homedir' is not exported by node_modules/rollup-plugin-node-polyfills/polyfills/os.js, imported by node_modules/@aws-sdk/credential-providers/node_modules/@aws-sdk/shared-ini-file-loader/dist-es/getHomeDir.js
```
As far as I can tell, it makes no sense to want a "homeDir" in the browser, so this may be an issue that should be raised with the AWS team. However, since it _is_ an export on the node module, I think that some form of support, such as defaulting to the project root, or a configurable option to set the dist or public folder may be in order.
What do you think?
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Start with polyfills/os.js and the failing import from @aws-sdk/shared-ini-file-loader/dist-es/getHomeDir.js. Confirm how the polyfill should handle Node's os.homedir export in a browser build, since the issue proposes several possible behaviors without choosing one. Done means the agreed behavior is supported and the reported Vite/Rollup import error no longer occurs.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript
- Área
- build-system, tooling
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100