ionic-team / ionic-team/rollup-plugin-node-polyfills

homeDir not exported by "os"

Open
#37 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
142
Forks
65
PR merge metrics
No merged PRs in 30d

Description

Hello,

Thanks for your work on this excellent and critical piece of OSS.

I am experiencing an issue trying to polyfill the node os module in a Vite build that bundles some pieces of the AWS javascript SDK v3 with my application. Specifically, AWS is trying to import `homeDir` from "os", which is a part of the node module [here](https://nodejs.dev/learn/the-nodejs-os-module/#oshomedir), but is not exported by `rollup-plugin-node-polyfills/polyfills/os.js`

```
Error: 'homedir' is not exported by node_modules/rollup-plugin-node-polyfills/polyfills/os.js, imported by node_modules/@aws-sdk/credential-providers/node_modules/@aws-sdk/shared-ini-file-loader/dist-es/getHomeDir.js
```

As far as I can tell, it makes no sense to want a "homeDir" in the browser, so this may be an issue that should be raised with the AWS team. However, since it _is_ an export on the node module, I think that some form of support, such as defaulting to the project root, or a configurable option to set the dist or public folder may be in order.

What do you think?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.