ionic-team / ionic-team/ionicons

ion icons not displayed if they are hosted on a server requesting auth

Open
#640 2 comments 0 reactions 0 assignees View on GitHub
help wanted type: bug
Dominant language
TypeScript
Stars
18.2k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Description

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request

**ionicons version:**
```
ionicons v4.4.6
```

Current behavior:
Currently the icon class gets the svg content without sending the cookies in microsoft edge on desktop and in every navigator on iPad. By default, fetch won't send or receive any cookies from the server, resulting in unauthenticated requests if the site relies on maintaining a user session (to send cookies, the credentials init option must be set). This means that those svgs can't be hosted on a server requesting auth.

Expected behavior:
I would expect that a credentials init option is set to same-origin or include.

If there are cases I haven't thought of, please let me know. I'd also be happy with a config option to change the value.

Contributor guide

Open the contributing guide

Research direction

Start by locating the icon class implementation that fetches SVG content and review how its fetch options are set. Reproduce the issue with icons hosted behind authentication in Edge or on an iPad, then verify that the request preserves the required session credentials and that existing unauthenticated icon loading still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.