ionic-team / ionic-team/ionicons

ionic 4 - prefix CDN domain before svg path of ionic components

Aperta
#1,056 7 commenti 5 reazioni 0 assegnatari Vedi su GitHub
help wanted type: bug
Lingua principale
TypeScript
Stelle
18.2k
Fork
2.1k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I am serving my application's "index.html" file from a different domain and my ionic application is hosted on CDN domain.

**Build Command**
`ng build --prod --aot --build-optimizer --output-hashing none --deploy-url https://myappv1.mycdn.in/`.

Here --deploy-url is my CDN domain.

**Current behavior:**
When I am using `` it's loading *.svg file dynamically. Whom path is related to "base-href" tag or hosted domain.

**Expected behavior:**
I want to prefix CDN domain before all *.svg file which is dynamically generating by ionic components so *.svg path will not be pointed to the hosted domain.

**Problem Statement**
Not getting the option to prefix CDN domain before *.svg file which is dynamically getting loaded by ionic components.

I am able to prefix the CDN domain before "assets" folder files but not able to do the same with ionic components related svg file. Because I don't know the entry point of the same.

**Proposed/Expected solution**
All ionic components lazy loaded files should have prefixed `--deploy-url` path. For example if my `--deploy-url https://myappv1.mycdn.in/` is while building my app. Svg file path of ionic components should be like `https://myappv1.mycdn.in/svg/md-arrow-back.svg`.

**Ionic Info**
Ionic CLI: 4.10.3
Angular CLI: 7.3.3
Node: 10.15.1
Npm: 6.8.0
OS: darwin x64 (macOs Mojave, Version: 10.14.1)

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by reproducing the issue with the stated Angular build command and the ion-back-button example. Trace how Ionic components dynamically construct the SVG path and compare it with the configured --deploy-url; done means the generated path uses https://myappv1.mycdn.in/ before the component SVG location.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
frontend, web-dev
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
38/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.