ionic-team / ionic-team/ionic-framework

Spacing scale: where do your spacing tokens live? (audit from the Rhythmguard benchmark)

Abierto
#31,430 0 comentarios 0 reacciones 0 asignados Ver en GitHub
triage
Lenguaje dominante
TypeScript
Estrellas
52.7k
Forks
13.3k
Merge medio
1 d 15 h
PR fusionados (30 d)
51

Descripción

# Spacing scale: where do your spacing tokens live? (audit from the Rhythmguard benchmark)

Hi. I maintain [stylelint-plugin-rhythmguard](https://github.com/PetriLahdelma/stylelint-plugin-rhythmguard), a Stylelint rule that checks spacing values against a project's own scale. To keep it quiet on code I do not control, I run it against public design systems on pinned commits and publish the numbers. This repository is one of them, and I would rather you saw the audit here than in a report first.

**What was run.** `npx rhythmguard audit . --scale auto` at `5874331` over `core/src/components`. Hairlines of one pixel or less, percentages, and generated or test paths are excluded. Anyone can reproduce it in a checkout of that commit.

**What it found.** The audit could not find a spacing token set here (it looks for `--space-*` / `--spacing-*` custom properties, Sass `$spacer` / `$spacing-*` variables and maps, or a Tailwind `--spacing` base), so it measured against a default 4px scale instead. Against that default it reported 8 literal values, a number that says more about my token discovery than about your CSS, so I am not treating it as a finding.

**The ask.** If you can point me at where the spacing scale is defined (a token file, a Sass map, a package), I will teach the tool to read it, re-run the audit on the real scale, and post the result here. If spacing is intentionally not on a scale, saying so is just as useful and I will mark the row that way.

The row for this repository will appear in a periodic "State of Spacing" table in the Rhythmguard repository, with this issue linked. If you would rather not be listed, say so here and I will remove it.

Feel free to close this if it is not useful. Thanks for the CSS.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by inspecting core/src/components at commit 5874331 and search for --space-*, --spacing-*, Sass spacing variables or maps, and a Tailwind spacing base. Done means identifying the token source for the issue author, or confirming that this repository intentionally has no spacing scale and replying with that result.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
css
Área
design, frontend
Tipo de issue
Documentación
Dificultad
1/5
Tiempo estimado
Menos de una hora
Estado de actividad
Activo
Claridad
Necesita aclaración
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.