ionic-team / ionic-team/ionic-framework

bug: setting an ion-label's textContent early results in double labels

Open
#30,749 2 comments 0 reactions 0 assignees View on GitHub
stencil type: bug
Dominant language
TypeScript
Stars
52.7k
Forks
13.3k
Avg merge
1d 15h
Merged PRs (30d)
51

Description

### Prerequisites

- [x] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#creating-an-issue).
- [x] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [x] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.

### Ionic Framework Version

v8.x

### Current Behavior

When setting a new `` instance's `textContent` before it is attached to the document and then after attaching it re-assigning a new `textContent` value will leave both visible.

See: https://codepen.io/ErikOnBike/pen/XJXqZxR

### Expected Behavior

The second assignment to the `textContent` property should remove the existing `textContent` value.

### Steps to Reproduce

See: https://codepen.io/ErikOnBike/pen/XJXqZxR

### Code Reproduction URL

https://codepen.io/ErikOnBike/pen/XJXqZxR

### Ionic Info

n/a

### Additional Information

This might be the effect of StencilJS' textContent patching. I'm not sure if I fully understand why StencilJS does all kinds of patching for WebComponents. It overrides things like `children`, `childNodes` and `textContent` which results in awkward behaviour if you're not following the standard Angular/Vite approach of dealing with DOM manipulation. I bumped into this a number of times now (I'm not using the mentioned frameworks).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.