ionic-team / ionic-team/ionic-framework

feat: Inline Action Sheets should have inline buttons as well

Open
#30,748 2 comments 0 reactions 0 assignees View on GitHub
type: feature request
Dominant language
TypeScript
Stars
52.7k
Forks
13.3k
Avg merge
1d 15h
Merged PRs (30d)
51

Description

### Prerequisites

- [x] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#creating-an-issue).
- [x] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [x] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already include this feature request, without success.

### Describe the Feature Request

Current inline action sheet design is a mix between inline and controller style as buttons are still done via a property instead of inline components. This forces consumers to still have to inject things like translation services for button description translation, etc.

### Describe the Use Case

When moving to inline components for dialogs etc. it would be great if the important part of the action sheet, namely its buttons were inline as well. This would allow us to use translation pipes, click directives for tracking etc. the same as we are doing it for all other buttons in an app.

### Describe Preferred Solution

Introduce action sheet button components for inline action sheet instead of using controller variable
```

{{'action.delete' | translate}}
{{'action.cancel' | translate}}

```

### Describe Alternatives

_No response_

### Related Code

_No response_

### Additional Information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.