ionic-team / ionic-team/ionic-framework

bug: Dark Theme: Toolbar and item-background colors doesn't follow the MD

Ouverte
#30,741 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
triage
Langage dominant
TypeScript
Étoiles
52.7k
Forks
13.3k
Merge moyen
1 j 15 h
PR mergées (30 j)
51

Description

# Bug Report

**Ionic version:**
[x] 5.x

**Current behavior:**

1. The toolbar on MD uses `--ion-background-color: #121212`.
2. The value of `--ion-item-background` is `#1A1B1E`

![dark_theme_before](https://user-images.githubusercontent.com/16899197/77822775-e5f4f580-7106-11ea-8e68-e4e4eeb1e100.PNG)
**Expected behavior:**

Based on [MD documentation](https://material.io/design/color/dark-theme.html)
1. The toolbar on MD should use `--ion-item-background` instead of `--ion-background-color: #121212`.
2. The value of `--ion-item-background` should be `#1d1d1d` instead of `#1A1B1E`

![dark_theme_after](https://user-images.githubusercontent.com/16899197/77822778-e8574f80-7106-11ea-9f45-3885d306843f.PNG)

**Steps to reproduce:**
Check the MD CSS provided in **Ionic Dark Theme** section from this [Ionic Documentation](https://ionicframework.com/docs/theming/dark-mode)

Thanks.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.