ionic-team / ionic-team/ionic-framework

bug: Angular HMR not working within ion-router-outlet

Aperta
#30,105 2 commenti 4 reazioni 0 assegnatari Vedi su GitHub
triage
Lingua principale
TypeScript
Stelle
52.7k
Fork
13.3k
Merge medio
1g 15h
PR unite (30g)
51

Descrizione

### Prerequisites

- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.

### Ionic Framework Version

v8.x

### Current Behavior

Angular hot module replacement does not work inside `ion-router-outlet` but it does work inside `router-outlet` but in that case Ionic life cycle events inherent to `ion-router-outlet` (`ionViewWillEnter`, `ionViewDidEnter`, etc...) are not being fired when hmr occurs (which is normal these event are only part of `ion-router-outlet`).
The same issue has already been reported in Angular repository at [https://github.com/angular/angular/issues/59243](https://github.com/angular/angular/issues/59243) with a link to a code reproduction url at [https://github.com/ReneZeidler/hmr-ionic-bug](https://github.com/ReneZeidler/hmr-ionic-bug), however it is also enough to create a new Ionic project and just make a change within a component inside `ion-router-outlet` to reproduce the issue.

### Expected Behavior

Angular hot module replacement should work inside `ion-router-outlet`.

### Steps to Reproduce

Refer to [https://github.com/angular/angular/issues/59243](https://github.com/angular/angular/issues/59243)

### Code Reproduction URL

https://github.com/ReneZeidler/hmr-ionic-bug

### Ionic Info

Ionic:

Ionic CLI : 7.2.0

Utility:

cordova-res : 0.15.4
native-run : not installed globally

System:

NodeJS : v20.10.0
npm : 10.2.3
OS : Windows 10

### Additional Information

_No response_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.