ionic-team / ionic-team/ionic-framework

bug: ionic-core and ionicons use different stencil versions which results in bundle warning

Aperta
#29,896 0 commenti 2 reazioni 0 assegnatari Vedi su GitHub
triage
Lingua principale
TypeScript
Stelle
52.7k
Fork
13.3k
Merge medio
1g 15h
PR unite (30g)
51

Descrizione

### Prerequisites

- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.

### Ionic Framework Version

v8.x

### Current Behavior

When building a Angular app using application bundler with esbuild I get the following warning, because ionic-core and ionicons use different stencil-core versions.

```
The import path @stencil/core/internal/app-data resolves to multiple files in the bundle:
[node_modules/.pnpm/@stencil+core@4.20.0/node_modules/@stencil/core/internal/app-data/index.js](javascript:void 0)
[node_modules/.pnpm/@stencil+core@4.21.0/node_modules/@stencil/core/internal/app-data/index.js](javascript:void 0)
The import path @stencil/core/internal/client resolves to multiple files in the bundle:
[node_modules/.pnpm/@stencil+core@4.20.0/node_modules/@stencil/core/internal/client/index.js](javascript:void 0)
[node_modules/.pnpm/@stencil+core@4.21.0/node_modules/@stencil/core/internal/client/index.js](javascript:void 0)
```

```
dependencies:
@ionic/angular 8.3.1
├─┬ @ionic/core 8.3.1
│ ├── @stencil/core 4.20.0
│ └─┬ ionicons 7.4.0
│ └── @stencil/core 4.21.0
└─┬ ionicons 7.4.0
└── @stencil/core 4.21.0
@ionic/core 8.3.1
├── @stencil/core 4.20.0
└─┬ ionicons 7.4.0
└── @stencil/core 4.21.0
ionicons 7.4.0
└── @stencil/core 4.21.0
```

### Expected Behavior

Since both are used together it would make sense they always use the same stencil versions.

### Steps to Reproduce

Install ionic and ionicons with versions above.

### Code Reproduction URL

Not required imo

### Ionic Info

Ionic:

Ionic CLI : 7.2.0 (/Users/marvin/.bun/install/global/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 8.3.1
@angular-devkit/build-angular : 18.2.6
@angular-devkit/schematics : 18.2.6
@angular/cli : 18.2.6
@ionic/angular-toolkit : not installed

Capacitor:

Capacitor CLI : 6.1.2
@capacitor/android : 6.1.2
@capacitor/core : 6.1.2
@capacitor/ios : 6.1.2

Utility:

cordova-res : not installed globally
native-run : not installed globally

System:

NodeJS : v22.7.0 (/opt/homebrew/Cellar/node/22.7.0/bin/node)
npm : 10.8.2
OS : macOS Unknown

### Additional Information

_No response_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.