ionic-team / ionic-team/ionic-framework

feat: refresher should have global css variable to control background

未关闭
#25,780 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
package: core type: feature request
主要语言
TypeScript
星标
52.7k
派生
13.3k
平均合并
1 天 15 小时
30 天内合并 PR
51

描述

### Prerequisites

- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.

### Ionic Framework Version

- [ ] v4.x
- [ ] v5.x
- [X] v6.x
- [ ] Nightly

### Current Behavior

Looks bad. 🤮 👎
![refresher-current](https://user-images.githubusercontent.com/60390085/185416186-2af00991-9825-4c02-94ee-0580633c62ce.gif)
(GIF colors are not accurate. In real it looks a bit uglier.)

### Expected Behavior

Look good. 😎 👍
![refresher-expected](https://user-images.githubusercontent.com/60390085/185416208-54890f73-70ba-4cef-bb71-3c73124e1114.gif)

### Steps to Reproduce

The refresher background and border should use either the same colors from item or card like `--ion-card-background` and `--ion-border-color` instead of `--ion-color-step-250` and `--ion-color-step-200`.

The current colors looks ugly if you define all color-step variable for light and dark mode. There are also other issues in Ionic with color-step in light mode. I guess this is only tested for dark mode. But in this case, it looks weird in both themes.

My current workaround:

```css
ion-refresher {
--ion-color-step-250: var(--ion-card-background);
--ion-color-step-200: var(--ion-border-color);
}
```

### Code Reproduction URL

https://codepen.io/infacto/pen/QWmzBez

### Ionic Info

`@ionic/angular: 6.1.8` (ionic info not available, ionic CLI not in use for my monorepo.)

### Additional Information

https://ionicframework.com/docs/api/refresher

https://github.com/ionic-team/ionic-framework/blob/436a8ce50847d26f8fb63ce64ea85be6f5c0bc8e/core/src/components/refresher/refresher.md.vars.scss#L12-L16

You can see e.g. the fallback `#ffffff` (white) of `--ion-color-step-250` which is gray, if set.

贡献指南

打开贡献指南

调研方向

Start with core/src/components/refresher/refresher.md.vars.scss, especially lines 12-16, and compare the behavior in the linked CodePen reproduction. Trace how the refresher background and border currently use the color-step variables. Done means the refresher exposes a global CSS variable for controlling these colors and its light and dark themes no longer produce the reported appearance.

由索引模型根据 Issue 内容生成。

评估

技术栈
css, typescript
领域
design, frontend
Issue 类型
功能
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。