ionic-team / ionic-team/ionic-framework
feat: platform.is should accept multiple values
- Langage dominant
- TypeScript
- Étoiles
- 52.7k
- Forks
- 13.3k
- Merge moyen
- 1 j 15 h
- PR mergées (30 j)
- 51
Description
### Prerequisites
- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already include this feature request, without success.
### Describe the Feature Request
I think platform.is should accept multiple values to help avoid multiple call with or
### Describe the Use Case
`this.platform.is('desktop', 'mobileweb', ...)`
instad of
`this.platform.is('desktop') || this.platform.is('mobileweb')`
### Describe Preferred Solution
_No response_
### Describe Alternatives
_No response_
### Related Code
_No response_
### Additional Information
_No response_
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Start by locating the TypeScript implementation and tests for `platform.is` in the Ionic framework. Review how platform values are currently accepted and checked, then define coverage for calls with multiple values. Done means the multi-value use case works without breaking existing single-value calls and the relevant tests pass.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- frontend
- Type d'issue
- Fonctionnalité
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100