ionic-team / ionic-team/ionic-framework

feat: accordion, improve customizability of toggle icons based on state and add label text

Aperta
#23,548 4 commenti 9 reazioni 0 assegnatari Vedi su GitHub
package: core type: feature request v6
Lingua principale
TypeScript
Stelle
52.7k
Fork
13.3k
Merge medio
1g 15h
PR unite (30g)
51

Descrizione

# Feature Request

**Ionic version:**

[ ] **4.x**
[ ] **5.x**
[X] **6.x**

**Describe the Feature Request**

Currently in our App we create a own Accordion Component, which i want to replace by the Ionic one in the Future. But we have two Icons, one for expanded and one for collapsed state, which does not rotate.

I wan't to be able to create it like this too. I can create a PR, but we should discuss the best was to implement this.

**Describe Solutions**

I understand that we can create a own Icon with Class `ion-accordion-toggle-icon` and then no extra Icon will be created. But because of this Class the icon will rotate between the states. So one Option would be to add a `toggleIconRotate: boolean` Prop. I don't like this option as the user has to check by himself if the accordion is collapsed or not and set the specific icon on his own.

**The better option** was if the accordion component would be able to do this itself. So maybe by setting the Type of `toggleIcon` to `string | {collapsed: string; expanded: string;}` and use two different icons based on the state. If this option is used the icon would not rotate.

**Additional Context**

What do you think? Do you prefer a Option? Should i create a PR?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.