ionic-team / ionic-team/ionic-framework

bug: disabling and sorting not working well with nested ion-reorder-group

Open
#23,022 7 comments 1 reaction 0 assignees View on GitHub
package: core type: bug
Dominant language
TypeScript
Stars
52.7k
Forks
13.3k
Avg merge
1d 15h
Merged PRs (30d)
51

Description

# Bug Report

**Ionic version:**

[ ] **4.x**
[x] **5.x**

**Current behavior:**

Nested `ion-reorder-group` is not working. I have a list of cards and in the list of cards I have a list of items. Now the user has the option to reorder the cards and the elements.

Naturally I created two reorder groups. One in the for the cards and one inside for the items.

However there now are a few problems:

1. Reorder elements from the item gets added to the cards reorder group. SO the cards reorder group gets triggered by the items
2. Disabled cards reorder group still gets its event triggered by the items (items reorder group is enabled)
3. Disabling item reorder group does not work when cards reorder group is enabled

**Expected behavior:**

Correctly add the `ion-reorder` elements only to its closest parent `ion-reorder-group`

**Steps to reproduce:**

**Related code:**

https://stackblitz.com/edit/ionic-5-angular-10-start-template-5jby2n?file=src%2Fapp%2Ftab1%2Ftab1.page.ts

Contributor guide

Open the contributing guide

Research direction

Start with the linked StackBlitz reproduction, especially src/app/tab1/tab1.page.ts, and reproduce nested ion-reorder-group behavior for cards and items. Done means each ion-reorder belongs only to its closest group and enabling or disabling either group does not trigger the other group's events.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.