ionic-team / ionic-team/ionic-framework
feat: return data from modal even when not explicitly calling dismiss method
- 主要语言
- TypeScript
- 星标
- 52.7k
- 派生
- 13.3k
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 51
描述
# Feature Request
**Ionic version:**
[x] **5.x**
**Describe the Feature Request**
My App currently displays a list with various items. The user can click on an item and edit it in a modal. When the modal dismisses, the list should show the changes the user had made.
I can use `this.modalCtrl.dismiss(value);` only if the user clicks on the "save" button. But I also want to pass the edited object to the previous page when the user swipes down to close the modal or clicks on the backdrop.
**Describe Preferred Solution**
A good solution would be an event that will be triggered if the modal is is going to be dismissed. A good example is the calendar app: https://streamable.com/7etj0s
This event could be used to prevent the modal from closing and show some info to the user. This event could also be used to trigger `this.modalCtrl.dismiss(value);` and pass data to page by using swipe-to-close.
**Describe Alternatives**
I tried to call `this.modalCtrl.dismiss(value);` in ionViewWillLeave. But the passed object was undefined.
贡献指南
调研方向
Start by reviewing the Ionic 5 modal dismissal lifecycle and ModalController behavior, focusing on swipe-to-close and backdrop dismissal. Compare the existing save-button data path with those dismissal paths; done means callers can receive edited data consistently and can prevent or react to dismissal.
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- typescript
- 领域
- frontend
- Issue 类型
- 功能
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100