ionic-team / ionic-team/ionic-framework
feat: select buttons should be more customizable
- Langage dominant
- TypeScript
- Étoiles
- 52.7k
- Forks
- 13.3k
- Merge moyen
- 1 j 15 h
- PR mergées (30 j)
- 51
Description
# Feature Request
**Ionic version:**
[x] **5.0.0**
**Describe the Feature Request**
Currently the [select API](https://ionicframework.com/docs/api/select) offers a way to set the cancel text with the [cancelText property](https://ionicframework.com/docs/api/select#properties), but not a way to edit the cancel icon when action sheet is used as interface.
**Describe Preferred Solution**
Add a `cancelIcon` property that can be used for action-sheet and alert interfaces. (For action sheet especially, there no styling difference between the cancel option and the others)
**Describe Alternatives**
When adding action sheet custom properties with a "buttons" property with a role "cancel", this doesn't erase the default cancel button either.
Take buttons properties, and use the role to erase any default role that would be set by the select component.
Following attempt (cf. suggested alternative) doesn't work:
TS file:
```typescript
// .ts file
customActionSheetOptions: any = {
buttons: [{
text: 'Cancel',
icon: 'close',
role: 'cancel'
}]
};
```
HTML file:
```html
doesn't change the icon of the cancel button
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Start with the Select API and its interfaceOptions handling for the action-sheet and alert interfaces. Trace how cancelText and default cancel buttons are assembled, then verify that a cancelIcon property and a custom cancel-role button produce the requested icon and do not leave a duplicate default button.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- frontend
- Type d'issue
- Fonctionnalité
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 38/100