ionic-team / ionic-team/ionic-framework

feat: select buttons should be more customizable

Open
#21,172 0 comments 0 reactions 0 assignees View on GitHub
package: core type: feature request
Dominant language
TypeScript
Stars
52.7k
Forks
13.3k
Avg merge
1d 15h
Merged PRs (30d)
51

Description

# Feature Request

**Ionic version:**
[x] **5.0.0**

**Describe the Feature Request**

Currently the [select API](https://ionicframework.com/docs/api/select) offers a way to set the cancel text with the [cancelText property](https://ionicframework.com/docs/api/select#properties), but not a way to edit the cancel icon when action sheet is used as interface.

**Describe Preferred Solution**
Add a `cancelIcon` property that can be used for action-sheet and alert interfaces. (For action sheet especially, there no styling difference between the cancel option and the others)

**Describe Alternatives**
When adding action sheet custom properties with a "buttons" property with a role "cancel", this doesn't erase the default cancel button either.

Take buttons properties, and use the role to erase any default role that would be set by the select component.

Following attempt (cf. suggested alternative) doesn't work:
TS file:
```typescript
// .ts file
customActionSheetOptions: any = {
buttons: [{
text: 'Cancel',
icon: 'close',
role: 'cancel'
}]
};
```
HTML file:
```html
doesn't change the icon of the cancel button

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.