ionic-team / ionic-team/ionic-framework

feat: max touches/min touches functionality should be added to the gesture utility

Open
#21,136 6 comments 8 reactions 0 assignees View on GitHub
package: core type: feature request
Dominant language
TypeScript
Stars
52.7k
Forks
13.3k
Avg merge
1d 15h
Merged PRs (30d)
51

Description

# Bug Report

**Ionic version:**

[x] **5.x**

**Current behavior:**
When navigating back using the swipeback gesture, it is possible to let the previous page jump and flicker by adding additional (multi touch) input using other fingers.

In practice, this happens accidentally when another part of the same or another hand covers the susceptible area (the previous page), resulting unwanted nav actions.

I don't even know whether this counts a bug, it's just a thing users have noticed and which feels a little bit off compared to the swipeback behaviour on iOS.

**Expected behavior:**
The page transition should be unaffected by additional touch input.

**Steps to reproduce:**
--> In an Ionic Angular App:
- Navigate to any page allowing you to either go- or swipe back
- Initiate a swipeback transition and add additional (multi touch) input to the leaving page

**Related code:**

None.

**Other information:**

![swipeback-bug](https://user-images.githubusercontent.com/819238/80343394-15ae2f00-8866-11ea-9545-e8c813307ffd.gif)

**Ionic info:**

```
Ionic:

Ionic CLI : 6.6.0 (/Users/xxx/.nvm/versions/node/v10.16.3/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 5.0.7
@angular-devkit/build-angular : 0.803.26
@angular-devkit/schematics : 8.3.26
@angular/cli : 8.3.26
@ionic/angular-toolkit : 2.2.0

Cordova:

Cordova CLI : 9.0.0 (cordova-lib@9.0.1)
Cordova Platforms : ios 5.1.1
Cordova Plugins : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.2.0, (and 4 other plugins)

Utility:

cordova-res (update available: 0.13.0) : 0.8.1
native-run : 1.0.0

System:

ios-deploy : 1.10.0
ios-sim : 8.0.2
NodeJS : v10.16.3 (/Users/xxx/.nvm/versions/node/v10.16.3/bin/node)
npm : 6.9.0
OS : macOS Catalina
Xcode : Xcode 11.4.1 Build version 11E503a
```

Contributor guide

Open the contributing guide

Research direction

Start by locating the gesture utility that handles the swipeback transition and inspect how it processes additional touch input. Reproduce the multi-touch swipeback case described in the issue, then verify that extra touches no longer alter or flicker the page transition.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.