ionic-team / ionic-team/ionic-cli

SCSS compilation using ionic 1 and gulp

Open
#2,901 2 comments 0 reactions 0 assignees View on GitHub
needs investigation
Dominant language
TypeScript
Stars
2k
Forks
682
PR merge metrics
No merged PRs in 30d

Description

This is an issue related to my ionic v1 project, and related to this issue: https://github.com/ionic-team/ionic-cli/issues/2859, while running `ionic serve`.

So basically I am assuming it's related to the watch and running gulp when modifying scss files.

In the previous version of the cli, when I would change a scss file, it would compile using gulp (based on the watch), and seem to do a hot reload of the compiled css file, without reloading the browser.

However, the behaviour now seems different:

1. As the scss file is changed, compilation to css starts
2. Browser gets refreshed
3. Compilation is done

This means another refresh is necessary to see the changes. So it seems that two changes are required (as far as I can tell).

1. Don't refresh browser on scss change
2. Hot reload the css file (assuming that is the mechanism being used)

Here is my ionic info details:
```
cli packages: (/Users/jacques/dev/mobile/node_modules)

@ionic/cli-utils : 1.19.0
ionic (Ionic CLI) : 3.19.0

global packages:

cordova (Cordova CLI) : 6.5.0
Gulp CLI : CLI version 3.9.1 Local version 3.9.1

local packages:

Cordova Platforms : none
Ionic Framework : ionic1 1.3.5

System:

ios-deploy : 1.9.2
Node : v6.11.0
npm : 2.15.12
OS : macOS High Sierra
Xcode : Xcode 9.1 Build version 9B55

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.