intuit / intuit/graphql-filter-java

FilterExpression doesn't work with LocalDateTime values

Open
#29 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
73
Forks
33
PR merge metrics
No merged PRs in 30d

Description

When passing in a LocalDateTime, the expression parser needlessly converts into a `Date`

image

image

This makes the filter unusable if you want to convert it to JPA format or SQL using `filterExpression.getExpression(ExpressionFormat.JPA);`

Contributor guide

Open the contributing guide

Research direction

Start at FilterExpression.getExpression(ExpressionFormat.JPA) and reproduce the reported behavior with a LocalDateTime value. Trace where the expression parser converts it to Date; done means JPA and SQL output preserve the LocalDateTime value and the existing filter behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.