intel / intel/Display-Virtualization-for-Windows-OS

Cursor size 128x128

Aperta
#40 15 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C++
Stelle
89
Fork
27
Merge medio
11m
PR unite (30g)
3

Descrizione

I noticed that in a recent commit:
https://github.com/intel/Display-Virtualization-for-Windows-OS/blame/47de3c4ef55a1c826332955cb40f2caef9bd4789/DVServerKMD/helper.h#L86
the cursor size was increased to 128×128, which is a welcome change especially for higher resolutions and for users who scale their cursor.

However, this appears to conflict with the virtio-gpu specification, which currently enforces a 64×64 cursor size.
https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-4040006

Because of this mismatch, the cursor appears corrupted when using stock QEMU.

I also found this commit in your Intel-distribution-of-QEMU repository which mitigates the issue:
https://github.com/intel/Intel-distribution-of-QEMU/commit/fa3963de817409e1dccbf6fdec7210020cf9a8ad

However, I’m not sure whether a change like this would be accepted upstream in QEMU.

Are there any plans to make this compatible with upstream QEMU? For example:

- proposing a patch to QEMU,
- updating the virtio specification to allow larger cursor sizes, or
- adding a compatibility fallback for 64×64 cursors?

I’d be interested to hear what the intended long-term approach is.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with DVServerKMD/helper.h around line 86, then compare the 128×128 cursor handling with the virtio 1.3 cursor limit and Intel-distribution-of-QEMU commit fa3963de817409e1dccbf6fdec7210020cf9a8ad. Done means agreeing on and implementing a compatibility path that works with stock QEMU, or documenting an accepted upstream/specification plan.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
cpp
Ambito
operating-systems
Tipo di issue
Bug
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Attiva
Chiarezza
Da chiarire
Idoneità per principianti
38/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.