intel / intel/Display-Virtualization-for-Windows-OS

Cursor size 128x128

Open
#40 15 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
89
Forks
27
Avg merge
11m
Merged PRs (30d)
3

Description

I noticed that in a recent commit:
https://github.com/intel/Display-Virtualization-for-Windows-OS/blame/47de3c4ef55a1c826332955cb40f2caef9bd4789/DVServerKMD/helper.h#L86
the cursor size was increased to 128×128, which is a welcome change especially for higher resolutions and for users who scale their cursor.

However, this appears to conflict with the virtio-gpu specification, which currently enforces a 64×64 cursor size.
https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-4040006

Because of this mismatch, the cursor appears corrupted when using stock QEMU.

I also found this commit in your Intel-distribution-of-QEMU repository which mitigates the issue:
https://github.com/intel/Intel-distribution-of-QEMU/commit/fa3963de817409e1dccbf6fdec7210020cf9a8ad

However, I’m not sure whether a change like this would be accepted upstream in QEMU.

Are there any plans to make this compatible with upstream QEMU? For example:

- proposing a patch to QEMU,
- updating the virtio specification to allow larger cursor sizes, or
- adding a compatibility fallback for 64×64 cursors?

I’d be interested to hear what the intended long-term approach is.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.