ins-amu / ins-amu/virtual_aging_brain
Upper triangle extraction of FCD includes zeros
- Dominant language
- Jupyter Notebook
- Stars
- 6
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Hello! @lrokos and I are reporting a bug in the extraction of the FCD upper triangle. `np.triu` is used, which returns an NxN array with zeros in the lower triangle. Consequently, subsequent calculations for metrics such as FCD variance include these zero entries.
For example, ahead of the FCD variance calculation, np.triu is used in [run_vab_github.py, line 215](https://github.com/ins-amu/virtual_aging_brain/blob/32efae569bb7984b69ca67d3b1dd30d5a53aa58a/scripts/run_vab_github.py#L215):
```
FCD_TRIU = np.triu(FCD, k=1)
<...>
FCD_VAR = np.var(FCD_TRIU)
```
We are working on a PR that aims to correct all occurrences.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.