influxdata / influxdata/influxdb-java

Batching Enhancements

Aperta
#289 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub
kind/enhancement
Lingua principale
Java
Stelle
1.2k
Fork
469
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I'm building an InfluxDB producer that I'd like to guarantee at-least-once delivery for. My throughput requirements are high enough that batching is required. I was happy when I found BatchProcessor but then realized a couple of shortcomings that are preventing me from using it. I'd rather improve this library than create my own batch producer. Here's where the current batch implementation is falling short. Are any of these being worked on currently?

1. There's no way to request the batch buffer to be flushed and not destroy the backing thread pool. The only option I see possible today without resorting to reflection is calling `InfluxDB.disableBatch` followed by `InfluxDB.enableBatch` to force a flush but that creates a new executor every time.
1. ~~`BatchProcessor.write()` is not thread safe and may be called concurrently from `BatchProcessor.flush()` on the current thread and the scheduled timer on the thread from the pool. This results in duplicate records being sent during `flush()`.~~
1. Batching records can silently fail. I'd like to provide a callback with each asynchronous write request that would be invoked once the point is sent or if an error was encountered while attempting to send it.
1. The consistency level for all BatchPoints produced by the BatchProcessor is `ConsistencyLevel.ONE`. Direct control over the consistently level would be nice but ONE is a show stopper.

Some of the above are fairly substantial deviations in behavior from the current version. Would it be worthwhile for this to be a separate batch implementation rather than migrating the current version? Perhaps create a new asynchronous interface named `InfluxDBAsync`?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Esamina innanzitutto l’API BatchProcessor esistente e il flusso di InfluxDB.disableBatch e InfluxDB.enableBatch. Determina se il flushing senza sostituire l’executor, le callback di errore asincrone, la consistenza configurabile e le scritture thread-safe debbano rientrare nell’implementazione attuale o in una nuova interfaccia InfluxDBAsync. Il lavoro è completato quando il design scelto soddisfa i requisiti di batching elencati senza lasciare silenziosi i fallimenti di consegna.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
databases
Tipo di issue
Funzionalità
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
25/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.