iMicknl / iMicknl/python-sagemcom-api
Add support for TalkTalk-branded router (UK)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 141
- Forks
- 49
- Avg merge
- 7h 54m
- Merged PRs (30d)
- 4
Description
## Model information
F5364 from TalkTalk
## Describe the bug
GetDeviceInfo is failing because this particular flavour of router doesn't have a ModelNumber.
Otherwise the library is working great!
Impact is that HA is unable to connect to the router since an exception is thrown in the setup.
## Expected behavior
I think ModelNumber is not important in the bigger scheme and could be defaulted to blank.
## Additional context
I've submitted a PR that fixes this - #386 - and also provides better support for ActionErrors when the request contains multiple xpaths.
[bug]
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the GetDeviceInfo path described in the issue and review PR #386, which already addresses the missing ModelNumber and adds ActionError handling for multiple xpaths. Done means the TalkTalk F5364 can complete setup when ModelNumber is absent, without the reported exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 20/100