iLPdev / iLPdev/discMapper

Deprecated: `sanitizeRoomName`

Open
#47 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Lua
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

As far as I can see, there's really no need for trimming lines from Discworld's ASCII map. Even if the user has options display set to left on the game, discMapper is pulling room titles directly from GMCP now - there's never going to be anything to sanitize. If it's not called anywhere else, we should just remove the whole thing rather than comment it out, right?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for sanitizeRoomName and its callers, then inspect the Discworld ASCII-map handling and GMCP room-title path mentioned in the issue. Done means the unused sanitizer and its references are removed only if no callers remain, with current room-title mapping preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.