hyperstack-org / hyperstack-org/hyperstack

Using HyperSpec when loading a page via `visit`

Open
#398 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
538
Forks
41
PR merge metrics
No merged PRs in 30d

Description

If you visit a page (rather than use `mount`) you don't get the HyperSpec extra stuff (like TimeCop integration, ability to use `before_mount`, `insert_html` etc.

Furthermore, when you call on_client the @hyper_spec_mounted flag is not set, and so the page will get reloaded.

You can work around the second part by doing a `page.instance_variable_set("@hyper_spec_mounted", true)` after the visit.

But this should all be nicely integrated, possibly some ERB helpers that could be used in test mode when loading the layout?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.