hyperstack-org / hyperstack-org/hyperstack

clear connection tables when transport is changed

未關閉
#346 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
JavaScript
星號
538
分支
41
PR 合併指標
30 天內沒有已合併 PR

描述

its possible to get pretty messed up when changing between transports, if you have data left in the connection tables.

Best to track which transport type is being used in the tables, and then clearing them out if it doesn't match the current type.

The key way things get messed up is that simple poller and pusher use the refresh_at field, while action_cable does not. So if you (for example) move from simple poller to action_cable, and you have some connections left in the table, things blow up. Best to put some safety around the refresh_at, so it gets ignored if you are in action_cable, instead of dying.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。