hyperstack-org / hyperstack-org/hyperstack

clear connection tables when transport is changed

Open
#346 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
538
Forks
41
PR merge metrics
No merged PRs in 30d

Description

its possible to get pretty messed up when changing between transports, if you have data left in the connection tables.

Best to track which transport type is being used in the tables, and then clearing them out if it doesn't match the current type.

The key way things get messed up is that simple poller and pusher use the refresh_at field, while action_cable does not. So if you (for example) move from simple poller to action_cable, and you have some connections left in the table, things blow up. Best to put some safety around the refresh_at, so it gets ignored if you are in action_cable, instead of dying.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.