hyperstack-org / hyperstack-org/hyperstack

add ability to mount a component from a router

Open
#287 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
538
Forks
41
PR merge metrics
No merged PRs in 30d

Description

If a component is mounted from a router, then it won't work unless it is actually mounted from that router.

This makes hyper-specs `mount` method not work directly.

Instead you have to create a wrapper component that looks like this:

```ruby
class RouteToProfile < HyperComponent
include Hyperstack::Router
param :id
render do
Switch do
Route('/profile/:id', mounts: UserProfile)
Route('/') { Redirect("/profile/#{id}") }
end
end
end
```

then you can mount `RouteToProfile` and pass the id.

It should be possible to add a `route` option to the mount method, that if present will do the above by using a predefined RouteToComponent method, that takes as parameters the component to mount, the hash of route params, and the route.

For example

```ruby
mount 'Profile', {id: 1}, route: '/profile/:id'
```

would translate to
```ruby
mount 'RouteToComponent', route: '/profile/:id', params: {id: 1}
```
which would dynamically figure everything out.

In the meantime the work around is to follow the pattern above.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.