hyperstack-org / hyperstack-org/hyperstack

es6 modules are assumed to have a default component

Abierto
#231 1 comentario 0 reacciones 0 asignados Ver en GitHub
bug good first issue
Lenguaje dominante
JavaScript
Estrellas
538
Forks
41
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

related to #185

ES6 modules may not always have a default component. For example `Material-UI`.

The problem is the `eval_native_react_component` method assumes if its an es6 module, then there must be a default. This causes that method to attempt to evaluate properties of `undefined`.

The fix is to check if its an es6 module AND does it have a default:

```ruby
module Hyperstack
module Internal
module Component
class ReactWrapper
...
def self.eval_native_react_component(name)
component = `eval(name)`
raise "#{name} is not defined" if `#{component} === undefined`
# ------------> the following && component.default needs to be added <-------------
component = `component.default` if `component.__esModule && component.default`
is_component_class = `#{component}.prototype !== undefined` &&
(`!!#{component}.prototype.isReactComponent` ||
`!!#{component}.prototype.render`)
has_render_method = `typeof #{component}.render === "function"`
unless is_component_class || stateless?(component) || has_render_method
raise 'does not appear to be a native react component'
end
component
end
end
end
end
end
```

As a work around you can do this in your pack files:
```javascript
Mui = require('@material-ui/core');
Mui.default = Mui // <--- add this line ----
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.