hyperstack-org / hyperstack-org/hyperstack

investigate having Tag#method_missing define method if found

Open
#182 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
538
Forks
41
PR merge metrics
No merged PRs in 30d

Description

The `method_missing` method in the Tag module does a rather expensive lookup to find the component class corresponding to the component method. We should experiment with defining the method once its found.

The only problem is that this will break obscure cases where component classes get redefined in new scopes. For example say you have a component `Foo::Baz` and you mount it within the `Foo::Bar::Bogus` component. Later you define a component `Foo::Bar::Baz`. If you don't dynamically lookup the component everytime, you won't find the new Baz.

I guess you could fix this by keeping track of all the components that have been defined, and then remove them if the new definition shadows them.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.