hyperlight-dev / hyperlight-dev/hyperlight

Remove legacy heap region from snapshot

Offen
#1,697 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
area/performance lifecycle/confirmed
Vorherrschende Sprache
Rust
Sterne
4.7k
Forks
208
Ø Merge
1 T. 7 Std.
Gemergte PRs (30 T.)
47

Beschreibung

For historical reasons, we have a "heap" region of memory in the snapshot, which is just a bunch of zero-initialised pages that bound the size of the heap. These are, in theory, never read from, only written to (upon which they will get CoW'd anyway), and have no real purpose existing, but bloat the size of the snapshot image. They are also all distinct physical pages when they are implicitly created in from_env (the space for them is included in `SandboxMemoryLayout::get_memory_size()`, so they are created when we make a memory buffer of that size), so the logic that deduplicates pages by GPA does not even work on them.

We should remove this region, and replace it with a VA region outside the snapshot image region that is unmapped by default, and maps to zero when a fault hits it. We can essentially reuse the logic from the stack region for this.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by tracing SandboxMemoryLayout::get_memory_size(), the snapshot image region, and the existing stack-region fault handling. The change is complete when the legacy heap pages are absent from snapshots and the replacement out-of-image VA region is unmapped by default but maps to zero on a fault.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
rust
Bereich
infrastructure
Issue-Typ
Refactoring
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
48/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.