hyperlight-dev / hyperlight-dev/hyperlight

Pin nightly rustfmt version to avoid cross-platform formatting inconsistencies

未关闭
#1,325 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
area/infrastructure lifecycle/confirmed question
主要语言
Rust
星标
4.7k
派生
208
平均合并
1 天 7 小时
30 天内合并 PR
47

描述

In #1324, we discovered that Linux and Windows CI runners had different `nightly` rustfmt versions installed, causing `just fmt-check` to fail with conflicting formatting expectations. Specifically, `nightly-2026-02-28` introduced a breaking change to how `use {crate1, crate2};` grouped imports are formatted (splitting them into separate `use` statements).

As a temporary fix, we pinned `nightly-2026-02-27` in the Justfile via a `nightly-toolchain` variable. This works but means we'll need to manually bump the pin when we want to pick up newer rustfmt features or when the pinned version becomes unavailable.

We should investigate a more permanent solution, such as:
- Pinning a nightly date in `rust-toolchain.toml` with a dedicated `nightly` profile for fmt
- Switching to stable rustfmt (if it covers our needs)
- Adding a `rustfmt.toml` option to explicitly control the import grouping behavior so it's resilient to upstream changes
- Setting up a recurring process/bot to bump the nightly pin intentionally

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。