hyperlight-dev / hyperlight-dev/hyperlight

Remove possibility of silent errors in `vmem::TableOps`

未关闭
#1,128 0 条评论 0 个 reaction 已指派 1 人 已被 @syntactically 认领 在 GitHub 查看
lifecycle/confirmed
主要语言
Rust
星标
4.7k
派生
208
平均合并
1 天 7 小时
30 天内合并 PR
47

描述

#1093 introduced
```rust
struct GuestPageTableBuffer {
buffer: std::cell::RefCell>,
}.
```
To avoid UB in the `into_bytes` implementation, this buffer made `Vec` instead of `Vec`. However this forced `read_entry` to possibly error silently using `unwrap_or(0)`.

We should remove the possibility of error occurring silently, either by panicking, or by rewriting `into_bytes` to avoid UB using `Vec`

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。