hyperlight-dev / hyperlight-dev/hyperlight
Check stack frames are correctly cleared when `hlt` is called
Open
area/security
lifecycle/confirmed
- Dominant language
- Rust
- Stars
- 4.7k
- Forks
- 208
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 47
Description
We should ensure that the call to `hlt` instruction is only made after everything has been torn down so we do not leak anything.
An idea of how to implement such a fix can be found at [PR comment](https://github.com/hyperlight-dev/hyperlight/pull/1072#issuecomment-3609786020).
Which basically says we should use minimal `assembly` that only calls a rust function and then runs `hlt`, which ensures anything has been torn down before calling `hlt`
Contributor guide
Assessment
This issue has not been assessed yet.