hyperledger / hyperledger/fabric-chaincode-java

Incorrect parsing of SSL certificates and keys in ChaincodeBase in external launcher case

Aberta
#220 6 comentários 0 reações 0 responsáveis Ver no GitHub
help wanted
Linguagem predominante
Java
Estrelas
323
Forks
210
Merge médio
8h 1min
PRs com merge (30d)
8

Descrição

ChaincodeBase attempts to parse SSL certificates and keys provided by an external launcher in the following manner:

```
final SslContext createSSLContext() throws IOException {
final byte[] ckb = Files.readAllBytes(Paths.get(this.tlsClientKeyPath));
final byte[] ccb = Files.readAllBytes(Paths.get(this.tlsClientCertPath));

return GrpcSslContexts.forClient().trustManager(new File(this.tlsClientRootCertPath))
.keyManager(new ByteArrayInputStream(Base64.getDecoder().decode(ccb)),
new ByteArrayInputStream(Base64.getDecoder().decode(ckb)))
.build();
}
```

This fails, because the certs deployed by the external builder are in PEM format, but the code attempts to Base64 decode them.

The fix is obvious, and I have used it successfully in testing (however, I would have to jump through a bunch of hoops to contribute it, so someone else should probably do it).

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.